Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow graceful_terminator to bind to an old named pipe #9

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Allow graceful_terminator to bind to an old named pipe #9

merged 5 commits into from
Jul 3, 2024

Conversation

omus
Copy link
Member

@omus omus commented Jul 2, 2024

Fixes this failure:

ERROR: LoadError: ArgumentError: could not listen on path /mnt/deputy-ipc/graceful-terminator.7
Stacktrace:
 [1] listen(path::String)
   @ Sockets /usr/local/julia/share/julia/stdlib/v1.9/Sockets/src/PipeServer.jl:79
 [2] graceful_terminator(f::var"#3#4"; set_entrypoint::Bool)
   @ K8sDeputy /usr/local/share/julia-depot/41c7a7947d/packages/K8sDeputy/tvrDX/src/graceful_termination.jl:87
 [3] graceful_terminator(f::Function)
   @ K8sDeputy /usr/local/share/julia-depot/41c7a7947d/packages/K8sDeputy/tvrDX/src/graceful_termination.jl:80
 [4] top-level scope
   ...

Only appears to occur when using DEPUTY_IPC_DIR and targeting a K8s volume which persists between restarts. Even an emptyDir persists for the lifetime of the pod.

github-actions[bot]
github-actions bot reviewed Jul 2, 2024
View reviewed changes
src/deprecated.jl Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (638971f) to head (8aa6585).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   89.33%   89.74%   +0.41%     
==========================================
  Files           4        4              
  Lines          75       78       +3     
==========================================
+ Hits           67       70       +3     
  Misses          8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omus omus requested a review from kleinschmidt July 3, 2024 14:22
kleinschmidt
kleinschmidt approved these changes Jul 3, 2024
View reviewed changes
src/graceful_termination.jl Outdated Show resolved Hide resolved
@omus omus merged commit 93c65e3 into main Jul 3, 2024
7 checks passed
@omus omus deleted the cv/bind-after-restart branch July 3, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kleinschmidt kleinschmidt kleinschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omus @kleinschmidt